Development#132
Merged
Merged
Conversation
… tests - Fix memory leak: dispose TextEditingController in dispose() - Fix inputRegExp silently ignored: now applied to FilteringTextInputFormatter - Fix unsafe onChanged when tryParse returns null: unparseable input silently ignored - Fix cursor position after step button: moves to end when digit count changes (9→10, 99→100) - Fix doc comments misalignment on placeholder/onChanged/value/disabled fields - Improve _regex: static final instead of getter (avoids allocation per access) - Improve step button UX: 0.4 opacity + tap suppressed at min/max boundaries - Add prefixIconDisabled/suffixIconDisabled to ThemedTextInput for disabled icon states - Add comprehensive widget tests for ThemedNumberInput (31 tests, all regression-verified) - Update ThemedNumberInput example showcase with full feature coverage - Bump version 7.5.24 → 7.5.25
… into development
📋 Changelog SummaryThis PR includes the following changes: ✨ Features
🐛 Bug Fixes
📊 Diff Stats
🤖 Auto-generated by changelog workflow |
📊 Test Coverage Report🎯 Dart/Flutter
🤖 Generated by coverage workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and changelog for the
ThemedNumberInputandThemedDurationInputFlutter widgets, clarifying their behavior, edge cases, and usage patterns. It also documents several recent bug fixes and improvements, including memory management, input validation, cursor handling, and enhanced visual feedback for step buttons. The changes provide comprehensive examples, testing guidance, and detailed explanations of widget parameters and behaviors.Documentation and Behavior Clarifications:
ThemedNumberInputandThemedDurationInputin.claude-plugin/skills/number-duration-inputs/SKILL.md, including:Bug Fixes and Improvements (as documented in
CHANGELOG.md):ThemedNumberInputmemory leak by properly disposing of itsTextEditingController.inputRegExpparameter being ignored; custom regex is now correctly applied to input filtering.onChangedcalls for unparseable input; such input is now ignored, preserving the last valid value.prefixIconDisabled/suffixIconDisabledsupport inThemedTextInput.Testing and Examples:
ThemedNumberInput, covering rendering, keyboard and button interactions, cursor behavior, locale formatting, lifecycle, and edge cases. [1] [2]Version and Example Updates:
7.5.26in.claude-plugin/plugin.json.example/lib/views/inputs/src/text.dartto include new fields for testing.