add Imports and Depends to DESCRIPTION #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm glad you like the package. This looks good. I'll first check the minimum R version that works, since I don't want to prevent people on outdated (but still working) R installation from being able to install the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice package.
This PR suggests a minor modification to the DESCRIPTION file.
I think it would be great to add
ImportsandDependsentries to the DESCRIPTION so that people can easily know the package is light-weighted and does not require many other packages installed from CRAN. I had to check the NAMESPACE and found out it only require utils package (and base R of course).As for the
Depends, I just checked time of the first commit for this package (Sept. 2015) and put in the latest version of R at that time. You may relax the requirement. But it would be good to have one. After all the package itself is about "versions".Feel free to decline this PR if you find it unnecessary.