Add ReturnTypeWillChange attributes and add workflows for PHP8.0 and PHP8.1#55
Merged
matthew-inamdar merged 4 commits intoJun 30, 2022
Merged
Add ReturnTypeWillChange attributes and add workflows for PHP8.0 and PHP8.1#55matthew-inamdar merged 4 commits into
matthew-inamdar merged 4 commits into
Conversation
added 4 commits
March 23, 2022 11:07
…rn types to support PHP8.1
…ssary for upgrade to new phpunit version
|
Any chance we could get this merged in? Rather broken on 8.1 atm 🙂 |
Contributor
Author
|
@matthew-inamdar Any possibility to get this merged? |
This was referenced Jun 30, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #53 , instead of adding the missing return types this PR adds the ReturnTypeWillChange attribute. It also adds PHP8.0 and PHP8.1 to the test matrix.