Skip to content

refactor: golem-llm -> golem-ai #38

Closed
rutikthakre wants to merge 6 commits into
golemcloud:mainfrom
rutikthakre:refactor
Closed

refactor: golem-llm -> golem-ai #38
rutikthakre wants to merge 6 commits into
golemcloud:mainfrom
rutikthakre:refactor

Conversation

@rutikthakre

@rutikthakre rutikthakre commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

After this PR project structure will be:
golem-llm (golem-ai)
├── Cargo.lock
├── Cargo.toml
├── golem-llm
│ ├── llm
│ ├── llm-anthropic
│ ├── llm-grok
│ ├── llm-ollama
│ ├── llm-openai
│ ├── llm-openrouter
│ ├── Makefile.toml
│ ├── README.md
│ ├── test
│ └── wit
├── LICENSE
└── Makefile.toml

/closes #29
/claim #29

@iambenkay

Copy link
Copy Markdown
Contributor

You did not need to update the models used in the integration tests. Generally you didn't need to touch the GitHub actions config.

@iambenkay

Copy link
Copy Markdown
Contributor
  1. The test directory itself should be independent of the subprojects, since all test for all domains will go in there
  2. You did not expose the necessary make tasks that the CI actually needs to pass. Your new makefile in the root is almost empty.
  3. You don't need to change any of the copy in the Cargo files. Focus on the restructure to reduce noise for the reviewers

Either you didn't put enough effort and thought into this Pull Request or you are not done yet in which case it should be marked as draft or not even uploaded yet, Read #36

@rutikthakre

rutikthakre commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

You did not need to update the models used in the integration tests. Generally you didn't need to touch the GitHub actions config.

You did not need to update the models used in the integration tests. Generally you didn't need to touch the GitHub actions config.

Yes, you are right here. I undo those changes.

@iambenkay

Copy link
Copy Markdown
Contributor

Your constant pushes are consuming the compute of the GitHub actions builder. Not sure but I guess it is because you made changes to the CI file. Try to complete all your changes locally first, then push all your commits at once. So that the compute does not keep getting consumed

@rutikthakre

rutikthakre commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author
  1. The test directory itself should be independent of the subprojects, since all test for all domains will go in there
  2. You did not expose the necessary make tasks that the CI actually needs to pass. Your new makefile in the root is almost empty.
  3. You don't need to change any of the copy in the Cargo files. Focus on the restructure to reduce noise for the reviewers

Either you didn't put enough effort and thought into this Pull Request or you are not done yet in which case it should be marked as draft or not even uploaded yet, Read #36

I will ignore this...

@vigoo

vigoo commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Closed in favor of #31

@vigoo vigoo closed this Jun 25, 2025
@rutikthakre rutikthakre deleted the refactor branch July 8, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor project structure to accommodate incoming changes with different AI domains

3 participants