Node stream support#66
Merged
Merged
Conversation
4 tasks
Closed
noise64
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial
node:streamsupport based on thewasmedge-quickjsimplementation (which is based on Deno).As part of this, had to also add
nextTickintonode:process.Note that this is the best approximation of Node's event loop that I could do without forking
rquickjsbut it is not perfect. We may need to further tweak it in the future.wasm-edge's event loop (which is also QuickJS based but not using
rquickjs) does the following:In wasm-rquickjs I could not add a separate nextTick queue in the middle of the event loop, so instead I am just using
deferto enqueue them - this basically adds a task in the end of QuickJS's own queue. So the only difference between our and the wasmedge event loop is that QuickJS's internal microtasks' and the user-defined nextTick tasks's order is not strictly defined.