Skip to content

Comments

feat: track migration modal close event in Matomo#728

Open
kgarbacinski wants to merge 3 commits intodevelopfrom
feature/dapp-1544-extend-matomo
Open

feat: track migration modal close event in Matomo#728
kgarbacinski wants to merge 3 commits intodevelopfrom
feature/dapp-1544-extend-matomo

Conversation

@kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@linear
Copy link

linear bot commented Feb 19, 2026

aziolek
aziolek previously approved these changes Feb 19, 2026
userSablierStreams?.sumAvailable;

const _onClosePanel = () => {
trackEventSafe('Migration', 'ModalClosed');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal can be closed before or after making a migration. Do we truly want to track that this way? May be hard to identify the conversion rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants