Repo#ls_tree - #67
Open
dometto wants to merge 2 commits into
Open
Conversation
dometto
commented
Jan 11, 2025
dometto
commented
Member
- add support for non-recursive lstree
- add support for lstree for specific path
* add support for non-recursive lstree * add support for lstree for specific path
bartkamphorst
requested changes
Jan 11, 2025
bartkamphorst
left a comment
bartkamphorst
left a comment
Member
There was a problem hiding this comment.
Review of the first set of comments, please see if they are still useful.
| results = [] | ||
| @repo.lookup(sha).tree.walk(:postorder) do |root, entry| | ||
| results << ::Gollum::Git::Tree.tree_entry_from_rugged_hash(entry, root) | ||
| def lstree(sha, path, options = {}) |
Member
There was a problem hiding this comment.
In RJGit adapter, the path argument in lstree has a default of nil. Should we do the same here?
| results << ::Gollum::Git::Tree.tree_entry_from_rugged_hash(entry, root) | ||
| def lstree(sha, path, options = {}) | ||
|
|
||
| if path |
Member
There was a problem hiding this comment.
What about:
tree = @repo.lookup(sha).tree
tree = tree / path if pathInstead of the if/else?
| end | ||
| results | ||
| else | ||
| tree.map do |entry| |
Member
There was a problem hiding this comment.
tree.map { |entry| Gollum::Git::Tree.tree_entry_from_rugged_hash(entry, root) }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.