Fix unimplemented functions mapping and CUDA TF32 precision setup#35
Merged
Conversation
returns a "not-implemented" error for new methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two main enhancements/fixes:
Unimplemented Functions Integration:
notimplemented.Functionintoxla.Function.newFunctionhelper to set up standard XLA error handling, raising an informative message ("{op} not implemented for XLA backend") when an unimplemented operation is called on the function.b.Main(),b.NewFunction(), andf.Closure()to usenewFunction.CUDA TF32 Precision Handling:
DotGeneralprecision settings for CUDA:DotGeneralPrecisionDefaultwhenDotGeneralUseTF32is enabled and accumulation dtype isF32(retaining TF32 performance).DotGeneralPrecisionHighestfor maximum accuracy.DotGeneralUseTF32to enable by default on CUDA backends (isPluginType(pluginName, "cuda")).