Skip to content

Conversation

@ntriller-plaid
Copy link
Contributor

Motivation

The init container image is hard coded in the template currently. This PR makes the image customizable so it can be pulled from a different location such as a private registry.

Backwards compatibility

  • There are no new required values.
  • The image is the same as before by default except that the image is fully qualified now, e.g. alpine:3.9 before and docker.io/library/alpine:3.9 after.

Tests

Added some helm unit tests:

helm unittest .

### Chart [ athens-proxy ] .

 PASS   tests/init_container_image_test.yaml
 PASS   tests/pdb_test.yaml

Charts:      1 passed, 1 total
Test Suites: 2 passed, 2 total
Tests:       5 passed, 5 total
Snapshot:    0 passed, 0 total
Time:        10.602792ms

@ntriller-plaid ntriller-plaid requested a review from a team as a code owner November 18, 2025 18:54
@ntriller-plaid ntriller-plaid force-pushed the nt-values-for-init-container-image branch from 63a7aff to 453a0db Compare November 18, 2025 18:57
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@DrPsychick DrPsychick merged commit bacdaff into gomods:main Nov 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants