Skip to content

fix(setup-report): avoid query-gas-limit by querying grants per cold->warm pair #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redstartechno wants to merge 1 commit into
base: upgrade-v0.2.14
Choose a base branch
from
+13 −10
Open

fix(setup-report): avoid query-gas-limit by querying grants per cold->warm pair #1307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions decentralized-api/internal/server/admin/setup_report.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,12 @@ func (s *Server) checkPermissions(ctx context.Context) Check {
warmKeyAddr := s.recorder.GetSignerAddress()

authzQueryClient := authztypes.NewQueryClient(s.recorder.GetClientContext())
grantsResp, err := authzQueryClient.GranteeGrants(ctx, &authztypes.QueryGranteeGrantsRequest{
// Query only the cold->warm pair. GranteeGrants scans the entire authz store
// (grants are keyed granter-first) and trips the node's query-gas-limit on a
// populated chain; Grants(granter,grantee) prefix-scans just this pair. Cf. the
// keeper's HasWarmKeyGrant.
grantsResp, err := authzQueryClient.Grants(ctx, &authztypes.QueryGrantsRequest{
Granter: coldKeyAddr,
Grantee: warmKeyAddr,
})

Expand All @@ -250,16 +255,14 @@ func (s *Server) checkPermissions(ctx context.Context) Check {
}
}

grantedFromColdKey := make(map[string]*authztypes.GrantAuthorization)
grantedFromColdKey := make(map[string]*authztypes.Grant)
for _, grant := range grantsResp.Grants {
if grant.Granter == coldKeyAddr {
var authorization authztypes.Authorization
if err := s.cdc.UnpackAny(grant.Authorization, &authorization); err != nil {
continue
}
if genericAuth, ok := authorization.(*authztypes.GenericAuthorization); ok {
grantedFromColdKey[genericAuth.Msg] = grant
}
var authorization authztypes.Authorization
if err := s.cdc.UnpackAny(grant.Authorization, &authorization); err != nil {
continue
}
if genericAuth, ok := authorization.(*authztypes.GenericAuthorization); ok {
grantedFromColdKey[genericAuth.Msg] = grant
}
}

Expand Down