feat: optional mTLS between DAPI and ML nodes#1329
Open
x0152 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Optional mTLS between the DAPI and ML nodes (alternative to #537).
Why
Protects all PoC endpoints with transport-level auth + encryption, instead of per-request signatures. Locks down PoC traffic both ways: only the holder of the pinned cert can reach the ML node's PoC port (8080) or post callbacks to the DAPI (9100). No CA, nothing expires - just two self-signed certs that pin each other. It's fully optional and off by default.
How to enable
Same host:
Remote ML node (separate machine):
Then:
MTLS_POC_CALLBACK_URL=https://dapi.example.com:9100.How to disable
Drop -f docker-compose.mtls.yml from the docker compose up command and restart:
There's no silent fallback - mTLS is fully off once the override file is removed.