Skip to content

feat: add exections_cancellable to sdk.create and export Execution #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

fiedlr
Copy link
Contributor

@fiedlr fiedlr commented Apr 16, 2025

  • add executions_cancellable to GoodDataSdk.create
  • Execution() instances are needed for the new cancelation method

risk: high

@fiedlr fiedlr force-pushed the afi-sdk-fix branch 3 times, most recently from f077b41 to 4619eb3 Compare April 16, 2025 16:36
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.35%. Comparing base (f6d2d7a) to head (4619eb3).
Report is 242 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
- Coverage   84.37%   83.35%   -1.03%     
==========================================
  Files         141      154      +13     
  Lines        9603    10423     +820     
==========================================
+ Hits         8103     8688     +585     
- Misses       1500     1735     +235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fiedlr fiedlr force-pushed the afi-sdk-fix branch 3 times, most recently from 57b3095 to f322ff6 Compare April 17, 2025 07:42
- Execution() instances are needed for the new cancelation method

risk: high
@fiedlr fiedlr enabled auto-merge April 17, 2025 08:14
@fiedlr fiedlr changed the title feat: add create_with_options and export Execution feat: add exections_cancellable to sdk.create and export Execution Apr 17, 2025
@fiedlr fiedlr merged commit 590b8fb into gooddata:master Apr 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants