Skip to content

feat(sdk-ui-filters): make date filter static period form accessible #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xMort
Copy link
Contributor

@xMort xMort commented Apr 2, 2025

JIRA: LX-975
risk: low


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests (optionally with keeping passing screenshots).
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --backstop --keep-passing-screenshots
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

@ivanmjartan ivanmjartan requested a review from Copilot April 10, 2025 10:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • libs/sdk-ui-filters/styles/scss/components/DateRangePicker.scss: Language not supported
  • libs/sdk-ui/src/base/localization/bundles/en-US.json: Language not supported
Comments suppressed due to low confidence (3)

libs/sdk-ui-filters/src/DateFilter/DateRangePicker/StartDateInputField.tsx:52

  • [nitpick] The displayName "FromInputField" does not align with the file name "StartDateInputField"; consider renaming it to "StartDateInputField" for consistency.
StartDateInputField.displayName = "FromInputField";

libs/sdk-ui-filters/src/DateFilter/DateRangePicker/EndDateInputField.tsx:55

  • [nitpick] The displayName "ToInputField" does not match the file name "EndDateInputField"; consider renaming it to "EndDateInputField" for consistency.
EndDateInputField.displayName = "ToInputField";

libs/sdk-ui-filters/src/DateFilter/DateRangePicker/DateTimePicker.tsx:238

  • The variable 'inputValue' is used but not declared; please ensure it is properly defined (e.g. using useState) to maintain controlled input behavior.
value={inputValue}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant