Skip to content

style: updating button icons and styles #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 22, 2025
Merged

style: updating button icons and styles #6228

merged 14 commits into from
Apr 22, 2025

Conversation

zdenekornst
Copy link
Contributor

@zdenekornst zdenekornst commented Apr 15, 2025 •
edited
Loading

risk: low

  1. UiButton spacing consistent for both icons and corrected for transparent ones
  2. UiButton smaller icon for small size
  3. UiButton correct hover styles for popout button
  4. IconType names synced with Figma (close/cross waiting to be resolved) edit: date also keeped for now (figma: calendar)
  5. Refactor SVG coloring and sizing (more to be done in future)`
  6. Detach shared styles between UiButton and UiChip

Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.

Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests (optionally with keeping passing screenshots).
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --backstop --keep-passing-screenshots
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

Commands for Bear platform working on branch rel/9.9

extended-test-legacy --backstop
extended-test-legacy --isolated
extended-test-legacy --record

@zdenekornst zdenekornst requested a review from kandl as a code owner April 15, 2025 07:15
@zdenekornst zdenekornst changed the title Button icons style: updating button icons and styles Apr 15, 2025
@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@zdenekornst
style: uibutton and uichip styling
0e8205d 
risk: low
@zdenekornst
style: hardcode white color for header component
59c3441 
risk: low
note: I run into some rethemed custom header, where it might do a problem, but didn't investigate more right now
@zdenekornst
style: revert to coloring icon via variable
bea93b1 
risk: low
@zdenekornst
style: revert to styling icon with variable
ad3573e 
risk: low
@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

@zdenekornst
Copy link
Contributor Author

extended-test --backstop

@github-actions GitHub Actions
Copy link

"extended-test --backstop" started. Check the progress here.

@github-actions GitHub Actions
Copy link

❌ "extended-test --backstop" finished with result failure. Check the results here.

kandl
kandl approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@kandl kandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kandl kandl enabled auto-merge April 22, 2025 13:55
@kandl kandl merged commit d616837 into master Apr 22, 2025
16 checks passed
@kandl kandl deleted the button-icons branch April 22, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kandl kandl kandl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdenekornst @kandl