fix: Remove focus before taking a screenshot in AddGranteeBase #6233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jkbmat wants to merge 1 commit into gooddata:master from jkbmat:cjma-LX-729-backstop-focus

Contributor

jkbmat commented Apr 15, 2025

risk: nonprod
JIRA: LX-729

Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.

Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

--backstop The command to run screen tests (optionally with keeping passing screenshots).
--integrated The command to run integrated tests against the live backend.
--isolated The command to run isolated tests against recordings.
--record The command to create new recordings for isolated tests.
--filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --backstop --keep-passing-screenshots
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

Commands for Bear platform working on branch rel/9.9

extended-test-legacy --backstop
extended-test-legacy --isolated
extended-test-legacy --record

jkbmat self-assigned this

Contributor Author

jkbmat commented Apr 15, 2025

extended-test --backstop

github-actions bot commented Apr 15, 2025

"extended-test --backstop" started. Check the progress here.

github-actions bot commented Apr 15, 2025

❌ "extended-test --backstop" finished with result failure. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 522971c to 9bd43ae Compare

April 15, 2025 14:57

Contributor Author

jkbmat commented Apr 15, 2025

extended-test --backstop

github-actions bot commented Apr 15, 2025

"extended-test --backstop" started. Check the progress here.

github-actions bot commented Apr 15, 2025

❌ "extended-test --backstop" finished with result failure. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 9bd43ae to f80e72e Compare

April 16, 2025 06:37

Contributor Author

jkbmat commented Apr 16, 2025

extended-test --backstop

github-actions bot commented Apr 16, 2025

"extended-test --backstop" started. Check the progress here.

github-actions bot commented Apr 16, 2025

❌ "extended-test --backstop" finished with result failure. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from f80e72e to 52b9840 Compare

April 16, 2025 08:21

Contributor Author

jkbmat commented Apr 16, 2025

extended-test --backstop

github-actions bot commented Apr 16, 2025

"extended-test --backstop" started. Check the progress here.

github-actions bot commented Apr 16, 2025

❌ "extended-test --backstop" finished with result failure. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 52b9840 to 4554eff Compare

April 16, 2025 09:08

Contributor Author

jkbmat commented Apr 16, 2025

extended-test --backstop

github-actions bot commented Apr 16, 2025

"extended-test --backstop" started. Check the progress here.

github-actions bot commented Apr 16, 2025

✅ "extended-test --backstop" finished with result success. Check the results here.

Contributor Author

jkbmat commented Apr 16, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 16, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 16, 2025

✅ "extended-test --backstop --keep-passing-screenshots" finished with result success. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 4554eff to 5788354 Compare

April 16, 2025 12:49

Contributor Author

jkbmat commented Apr 16, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 16, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 16, 2025

❌ "extended-test --backstop --keep-passing-screenshots" finished with result failure. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 5788354 to 9e621b9 Compare

April 16, 2025 13:51

Contributor Author

jkbmat commented Apr 16, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 16, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 17, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 17, 2025

❌ "extended-test --backstop --keep-passing-screenshots" finished with result failure. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from f96b33f to f4ce7f5 Compare

April 17, 2025 08:26

Contributor Author

jkbmat commented Apr 17, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 17, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 17, 2025

✅ "extended-test --backstop --keep-passing-screenshots" finished with result success. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch 2 times, most recently from 3b05299 to 0393002 Compare

April 17, 2025 09:01

jkbmat marked this pull request as ready for review

April 17, 2025 09:02

jkbmat requested a review from kandl as a code owner

April 17, 2025 09:02

jkbmat requested a review from ivan-nejezchleb

April 17, 2025 09:03

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 0393002 to c6f315b Compare

April 17, 2025 09:35

Contributor Author

jkbmat commented Apr 17, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 17, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 17, 2025

❌ "extended-test --backstop --keep-passing-screenshots" finished with result failure. Check the results here.

Contributor Author

jkbmat commented Apr 17, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 17, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from c6f315b to 6cac590 Compare

April 17, 2025 11:09

Contributor Author

jkbmat commented Apr 17, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 17, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 17, 2025

❌ "extended-test --backstop --keep-passing-screenshots" finished with result failure. Check the results here.

Contributor Author

jkbmat commented Apr 17, 2025

extended-test --backstop --keep-passing-screenshots

github-actions bot commented Apr 17, 2025

"extended-test --backstop --keep-passing-screenshots" started. Check the progress here.

github-actions bot commented Apr 17, 2025

✅ "extended-test --backstop --keep-passing-screenshots" finished with result success. Check the results here.

jkbmat force-pushed the cjma-LX-729-backstop-focus branch 2 times, most recently from 8066444 to 0393002 Compare

April 17, 2025 12:26


          fix: Remove focus before taking a screenshot in AddGranteeBase

ea079bc

risk: nonprod
JIRA: LX-729

jkbmat force-pushed the cjma-LX-729-backstop-focus branch from 0393002 to ea079bc Compare

April 17, 2025 12:26

ivan-nejezchleb approved these changes

View reviewed changes

Contributor

ivanmjartan commented Apr 17, 2025

You need to create PR from upstream not from your fork this Jenkinc call will not work (FOSSA check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet