Skip to content

feat: add onDataView callback to visualization components #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

no23reason
Copy link
Contributor

This optional callback can be used to get notified whenever the visualization loads new data. This can be used to display some extra UI elements based on the data being empty, partially empty, etc.

For now added as alpha, pending some feedback from internal use.

JIRA: CQ-1287
risk: low


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests (optionally with keeping passing screenshots).
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --backstop --keep-passing-screenshots
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

Commands for Bear platform working on branch rel/9.9

extended-test-legacy --backstop
extended-test-legacy --isolated
extended-test-legacy --record

@no23reason no23reason requested a review from kandl as a code owner April 16, 2025 12:49
@no23reason no23reason force-pushed the dho/cq-1287-on-data-view branch 3 times, most recently from ae49236 to ded5f6f Compare April 17, 2025 07:52
This optional callback can be used to get notified whenever the
visualization loads new data. This can be used to display some extra
UI elements based on the data being empty, partially empty, etc.

For now added as alpha, pending some feedback from internal use.

JIRA: CQ-1287
risk: low
@no23reason no23reason force-pushed the dho/cq-1287-on-data-view branch from ded5f6f to 27be279 Compare April 17, 2025 11:17
Copy link
Contributor

@kandl kandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@no23reason no23reason enabled auto-merge April 17, 2025 13:00
@no23reason no23reason merged commit bcce6d0 into master Apr 17, 2025
16 checks passed
@no23reason no23reason deleted the dho/cq-1287-on-data-view branch April 17, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants