-
Notifications
You must be signed in to change notification settings - Fork 0
Add chorus effect with UI controls #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Implement Chorus struct with delay line and LFO modulation - Add chorus to Stage struct audio processing pipeline - Add WASM bindings for chorus effect controls - Add UI toggle and mix amount slider in debug-ui - Wire chorus effect to final stage output before limiter Co-authored-by: Brian Hurlow <[email protected]>
|
@claude I would like the chorus implementation to be in an |
|
Claude finished @bhurlow's task —— View job Todo List:
✅ CompleteSuccessfully reorganized the chorus effect into an
The chorus effect is now properly organized in the |
Move chorus implementation from filters to effects directory as requested. This provides better organization for future effect additions. Co-authored-by: Brian Hurlow <[email protected]>
- Create new effects directory structure - Move chorus implementation from filters to effects - Update imports in stage.rs and lib.rs - Remove chorus references from filters module This provides better organization for future effect additions. Co-authored-by: Brian Hurlow <[email protected]>
|
@claude this doesn't sound particularly chorusy or good. Add an intensity slider along with the % mix, and increase the modulation amount |
|
Claude finished @bhurlow's task —— View job ✅ CompleteSuccessfully enhanced the chorus effect with an intensity parameter and improved modulation characteristics. The chorus should now sound much more chorusy and dynamic! Todo List:
Improvements Made:🎛️ New Intensity Parameter:
🎵 Enhanced Chorus Algorithm:
🔧 Technical Implementation:
The chorus effect should now sound much more chorusy and provide better control over the effect intensity. The combination of increased modulation depth, faster LFO, and the new intensity parameter should address the original feedback about the effect being too subtle. |
…ulation - Add intensity parameter to Chorus struct (0.0-1.0 range) - Increase default modulation depth from ±5ms to ±10ms for more chorusing - Improve LFO frequency from 0.5 Hz to 1.2 Hz for more classic sound - Intensity scales both modulation depth and LFO frequency dynamically - Add intensity slider to UI alongside existing mix control - Update WASM bindings with intensity parameter - Default intensity is 0.7 (70%) for a good balance Co-authored-by: Brian Hurlow <[email protected]>
Add optional chorus effect to the final stage output with toggle and effect amount controls in the debug-ui.
Implementation includes:
Resolves ##57
Generated with Claude Code