fix: Correctly adapt starlette BaseUser to A2A User #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapydapy
previously requested changes
May 28, 2025
mikeas1
force-pushed
the
fix-starlette-auth
branch
from
22984c6 to
2844180
Compare
pstephengoogle
approved these changes
Jun 2, 2025
pstephengoogle
dismissed
swapydapy’s stale review
unblocking as this was addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes using the Starlette
BaseUserclass as ourauth.User. I was previously markingBaseUseras a virtual subclass ofauth.User, butauth.Useris not compatible (it's closer to the flask-login user).