Don't handle special case of reductions for scalar inputs and "empty" reduction axes#6322
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Don't handle special case of reductions for scalar inputs and "empty" reduction axes#6322copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_882225739
branch
3 times, most recently
from
75ad313 to
af7e28c
Compare
… reduction axes
TFlite has a wierd thing where it allows specifying that the shape `{0}` (not `{}`) means "scalar" or empty. XNNPACK does not have this special case, and I don't think we should support it.
PiperOrigin-RevId: 882225739
copybara-service
bot
force-pushed
the
test_882225739
branch
from
af7e28c to
71d7d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't handle special case of reductions for scalar inputs and "empty" reduction axes
TFlite has a wierd thing where it allows specifying that the shape
{0}(not{}) means "scalar" or empty. XNNPACK does not have this special case, and I don't think we should support it.