Skip to content

Fix/replace print with logging #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manaspros wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix/replace print with logging #200

manaspros wants to merge 9 commits into from

Conversation

@manaspros
Copy link
Contributor

@manaspros manaspros commented Jan 14, 2026

Fixes #187

This PR replaces all print() calls in the concordia package with proper structured logging using absl.logging, which is already a project dependency.

Benefits

  • Better control over log levels (info, debug, warning, error)
  • Timestamps and module context in log output
  • Ability to filter/suppress output programmatically
  • Consistent logging approach across the codebase

Changes

  • Added from absl import logging imports where needed
  • Replaced print() with appropriate logging levels:
    • logging.info() for informational output
    • logging.debug() for verbose/debug output
    • logging.warning() for warnings
    • logging.error() for error conditions
  • Used %s formatting style for better performance
  • Preserved termcolor.colored() calls for colored output

Files Modified

  • Core engine files (sequential.py, simultaneous.py, parallel_questionnaire.py, sequential_questionnaire.py)
  • Game master components (next_acting.py, scene_tracker.py, questionnaire.py, open_ended_questionnaire.py, payoff_matrix.py, inventory.py)
  • Language model implementations (6 files in contrib/language_models/)
  • Utilities (profiler.py with 38 statements, helper_functions.py, thought_chains.py, call_limit_wrapper.py)
  • Simulation prefabs (generic.py, questionnaire_simulation.py)
  • Environment configuration and scene runners
  • Agent implementations
  • All contrib and deprecated components (46+ files)

Testing

  • ✅ All 144 tests pass with no new failures
  • ✅ Verified 0 print() statements remain in concordia/ package (examples/ excluded as per maintainer guidance)

Total Impact

  • 71 files modified
  • 256 print() statements replaced

@manaspros manaspros mentioned this pull request Jan 14, 2026
Open
@locross93 locross93 self-requested a review January 26, 2026 14:27
locross93
locross93 requested changes Jan 26, 2026
View reviewed changes
Copy link
Collaborator

@locross93 locross93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @manaspros! The migration to absl.logging looks useful and good to provide better logging control.

Requested changes:

Please remove changes to all files under deprecated/ paths. We are in the process of removing these deprecated components from the codebase, so making changes to them creates unnecessary churn.

Once these files are removed from the PR, I'm happy to approve!

@manaspros
Copy link
Contributor Author

manaspros commented Jan 26, 2026

@locross93 Check and let me know

locross93
locross93 requested changes Jan 26, 2026
View reviewed changes
manaspros and others added 7 commits January 26, 2026 22:16
@manaspros
Replace print() statements with absl.logging
529846a 
Fixes google-deepmind#187

This PR replaces all print() calls in the concordia package with proper
structured logging using absl.logging, which is already a project dependency.

This provides:
- Better control over log levels (info, debug, warning, error)
- Timestamps and module context in log output
- Ability to filter/suppress output programmatically
- Consistent logging approach across the codebase

Changes:
- Added 'from absl import logging' imports where needed
- Replaced print() with appropriate logging levels:
  - logging.info() for informational output
  - logging.debug() for verbose/debug output
  - logging.warning() for warnings
  - logging.error() for error conditions
- Used %s formatting style for better performance
- Preserved termcolor.colored() calls for colored output

Files modified include:
- Core engine files (sequential.py, simultaneous.py, etc.)
- Game master components
- Language model implementations
- Utilities (profiler.py with 38 statements, helper_functions.py, etc.)
- Simulation prefabs
- All contrib and deprecated components

Testing:
- All 144 tests pass
- Verified 0 print() statements remain in concordia/ package
@manaspros
Fix import conflict in world_background_and_relevance.py
4cf9924 
Remove unnecessary absl.logging import that was conflicting with
standard library logging module. This file uses logging.getLogger()
which is not available in absl.logging.
@manaspros
Fix logging import conflict in industrial_action.py
6063af5 
Use alias 'absl_logging' for absl.logging to avoid conflict with
concordia.typing.logging module which defines LoggingChannel types.
@manaspros
Revert "Merge branch 'main' into fix/replace-print-with-logging"
b4cde47 
This reverts commit 129118c, reversing
changes made to 485ddbd.
@manaspros
Revert "Merge branch 'main' into fix/replace-print-with-logging"
e4ffdaf 
This reverts commit 129118c, reversing
changes made to 485ddbd.
@manaspros
Revert "Replace print statements with logging in deprecated metrics m…
b80e170 
…odules"

This reverts commit 485ddbd.
@manaspros
Restore deprecated directory to upstream state
a17e192
@manaspros manaspros force-pushed the fix/replace-print-with-logging branch from 5b589d6 to a17e192 Compare January 26, 2026 16:51
@manaspros
Copy link
Contributor Author

manaspros commented Jan 26, 2026

Sorry for so many commits changes

@manaspros
Copy link
Contributor Author

manaspros commented Jan 26, 2026

Should i also remove concordia/components/agents/depreciated? @locross93

@locross93 locross93 self-requested a review January 26, 2026 17:15
@locross93
Copy link
Collaborator

locross93 commented Jan 26, 2026

Remove any changes you made to concordia/components/agents/depreciated but don't remove the path if that is what you meant

@manaspros
Copy link
Contributor Author

manaspros commented Jan 26, 2026

Now everything is done u can merge

@locross93
Copy link
Collaborator

locross93 commented Jan 26, 2026

We got this error on our end preventing a merge: error: Error moving 'release/CHEATSHEET.md'. It doesn't exist in the workdir

Can you make sure your code is up to date with the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@locross93 locross93 locross93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor print() calls to use structured logging (absl.logging)

2 participants

@manaspros @locross93