Fix gin-config compatibility error in rl_unplugged notebooks #672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
Problem
Running
from rl_unplugged import atariin Colab raises:TypeError: configurable() got an unexpected keyword argument 'blacklist'This occurs because
dopamine-rl==3.1.2uses gin-config's deprecatedblacklistparameter, which was renamed todenylistin newer gin-config versions.Solution
Pin
gin-config==0.3.0in the notebook installation cells (this version is already specified inrequirements.txt).Changes
atari_dqn.ipynb: Added!pip install gin-config==0.3.0before dopamine-rlbsuite.ipynb: Added!pip install gin-config==0.3.0before dopamine-rltest_atari_import.py: Added test to verify the import works without TypeErrorNote: This PR addresses the
atari_dqn.ipynberror from issue #428. Thedmlab_r2d2.ipynbbazel build issue is a separate infrastructure problem with DeepMind Lab that requires upstream fixes.