Replace (Haiku internal) PRNGKey with jax.Array.
#858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_852726459
branch
2 times, most recently
from
eb532bb to
335e9de
Compare
As noted in JAX docs [0] the correct type for PRNG keys in JAX is simply `jax.Array`. In #857 there was some confusion that Haiku's internal type alias might be causing typing issues for users code, so to make things simpler I am removing the alias in favour of using `jax.Array` as recommended. [0] https://docs.jax.dev/en/latest/jep/9263-typed-keys.html#type-annotations-for-prng-keys PiperOrigin-RevId: 852755180
copybara-service
bot
force-pushed
the
test_852726459
branch
from
335e9de to
d45d6f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace (Haiku internal)
PRNGKeywithjax.Array.As noted in JAX docs [0] the correct type for PRNG keys in JAX is simply
jax.Array. In #857 there was some confusion that Haiku's internal type aliasmight be causing typing issues for users code, so to make things simpler I
am removing the alias in favour of using
jax.Arrayas recommended.[0] https://docs.jax.dev/en/latest/jep/9263-typed-keys.html#type-annotations-for-prng-keys