Fix opt_state type mismatch when restoring checkpoints with Adam/LAMB optimizers - #105
Merged
Merged
Conversation
… optimizers When using Adam or LAMB optimizers with reset_if_nan=True, the opt_state loaded from checkpoint is a list but should be a tuple. This causes jax.lax.cond at train.py:315 to fail during training. Convert opt_state_ckpt to tuple when restoring from checkpoint to ensure type consistency.
jsspencer
approved these changes
Aug 12, 2025
copybara-service
Bot
merged commit Sep 17, 2025
ce6b3c8
into
google-deepmind:main
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Adam or LAMB optimizers with reset_if_nan=True, the opt_state loaded from checkpoint is a list but should be a tuple. This causes jax.lax.cond at train.py:315 to fail during training. Convert opt_state_ckpt to tuple when restoring from checkpoint to ensure type consistency.