-
Notifications
You must be signed in to change notification settings - Fork 125
Erdős Problem 125 #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Erdős Problem 125 #1234
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
callesonne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Looks good to me after these comments have been addressed :)
|
|
||
| @[category research open, AMS 11] | ||
| theorem erdos_125 : | ||
| ({ x : ℕ | (digits 3 x) ⊆ {0, 1} } + { x : ℕ | (digits 4 x) ⊆ {0, 1} }).HasPosDensity ↔ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ({ x : ℕ | (digits 3 x) ⊆ {0, 1} } + { x : ℕ | (digits 4 x) ⊆ {0, 1} }).HasPosDensity ↔ | |
| { x : ℕ | (digits 3 x).toFinset ⊆ {0, 1} } + { x : ℕ | (digits 4 x).toFinset ⊆ {0, 1} }.HasPosDensity ↔ |
Apparently here {0, 1} is treated as a list, because List has an instance of the Insert class, which is used to implement the notation { } for writing e.g. {a, b}. So the statement currently says that x has first digit 0 and second digit 1 (i.e. x = 3 or x = 4). I've suggested a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The round brackets are mandatory for .HasPosDensity to take the full set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I forgot you were doing addition inside the brackets, my bad!
| ({ x : ℕ | (digits 3 x).toFinset ⊆ {0, 1} } + { x : ℕ | (digits 4 x).toFinset ⊆ {0, 1} } | ||
| ).HasPosDensity ↔ answer(sorry) := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ({ x : ℕ | (digits 3 x).toFinset ⊆ {0, 1} } + { x : ℕ | (digits 4 x).toFinset ⊆ {0, 1} } | |
| ).HasPosDensity ↔ answer(sorry) := by | |
| theorem erdos_125 : | |
| ({ x : ℕ | (digits 3 x).toFinset ⊆ {0, 1} } + | |
| { x : ℕ | (digits 4 x).toFinset ⊆ {0, 1} }).HasPosDensity ↔ answer(sorry) := by |
Final formatting suggestion :)
callesonne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once this final formatting comment has been addressed :) Thanks a lot!
fix #366