chore: create a FormalConjecturesTest library #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
reviewed
Jan 9, 2026
Member
YaelDillies
left a comment
YaelDillies
left a comment
There was a problem hiding this comment.
Are you intending this new library to allow warnings?
YaelDillies
changed the title
Member
Author
@YaelDillies Allowing warnings seems reasonable to me - what do you think? |
Member
|
I was hoping we would instead remove them with |
Member
Author
Sounds reasonable. I've turned off sorry warnings - are there any other options I should turn off? |
Member
|
Wait, why would you turn off sorry warnings here? Will this library use sorry outside out tests (where they should be caught by |
Member
Author
|
I think it's reasonable to turn sorry warnings off in tests with |
Member
|
Can you fix the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a separate test library with tests for definitions and some of the metaprograms from
FormalConjectures/Util. The intent here is to have a slightly clearer repo structure.