fix(Wikipedia/WallSunSun): restrict D to fundamental discriminants
#1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all integers appear as discriminants of a quadratic field.
eric-wieser
reviewed
Jan 21, 2026
Comment on lines
43
to
44
| /-- Fundamental discriminants are those integers `D` that appear as discriminants of quadratic | ||
| fields. |
Member
There was a problem hiding this comment.
Does mathlib not have the notion of a discriminant of a quadratic field?
Member
Author
There was a problem hiding this comment.
Sure it does, but the notion of fundamental discriminant can be described very elementarily. That it corresponds to discriminants of quadratic fields is definitely something we should state, if that's what you mean
Member
There was a problem hiding this comment.
This could be a nice category test or category undergradute statement!
YaelDillies
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all integers appear as discriminants of a quadratic field.