-
Notifications
You must be signed in to change notification settings - Fork 209
chore: bump mathlib to v4.27.0 #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Originally done in #1371. Co-authored-by: Bolton Bailey <bolton.bailey@gmail.com>
|
Does this build at every intermediate commit? Note that currently nothing is green. |
|
Would you want |
|
I suppose all that really matters is that |
|
as @eric-wieser said, only |
| -/ | ||
|
|
||
| -- A standard set of imports for open problems. | ||
| import Counterexamples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
motzkin_polynomial_nonneg was moved to Counterexamples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure any care has been taken to make Counterexampless reasonable to import (besides the fact that doc-gen checks names don't clash with mathlib); I'd be more comfortable just sorrying out
formal-conjectures/FormalConjectures/HilbertProblems/17.lean
Lines 52 to 56 in f01550c
| theorem f_nonneg : ∀ x y : ℝ, 0 ≤ f.eval ![x, y] := by | |
| intro x y | |
| unfold f | |
| simp | |
| exact Real.motzkin_polynomial_nonneg x y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or inlining the short proof with a comment)
|
@YaelDillies what's the issue with the String API? (I suspect this might be showing up in code i wrote, so happy to look into this) |
|
I now locally have a sequence of bump commits that succeed on @Paul-Lez, the issue with strings is that the substring API changed completely and most of the functions are now deprecated. Could you have a look at the CI failure and address it? Feel free to push to this branch, I can deal with the conflicts with my local version. |
|
@YaelDillies Sounds good, will take a look! |
No description provided.