-
Notifications
You must be signed in to change notification settings - Fork 210
feat: add optimization constants #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
felixpernegger
wants to merge
4
commits into
google-deepmind:main
Choose a base branch
from
felixpernegger:optimizationconstants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /- | ||
| Copyright 2025 The Formal Conjectures Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| -/ | ||
|
|
||
| import FormalConjectures.Util.ProblemImports | ||
|
|
||
| /-! | ||
| # Tao's Optimization constant 1a / An autocorrelation constant related to Sidon sets | ||
|
|
||
| *References:* | ||
| - [Tao's optimization constant 1a](https://teorth.github.io/optimizationproblems/constants/1a.html) | ||
| - [M2010] Matolcsi, Máté, and Carlos Vinuesa. "Improved bounds on the supremum of autoconvolutions." | ||
| Journal of mathematical analysis and applications 372.2 (2010): 439-447. [arXiv:0907.1379](https://arxiv.org/abs/0907.1379) | ||
| - [Y2026] Yuksekgonul, Mert et al., "Learning to Discover at Test Time," 2026, [arXiv:2601.16175](https://arxiv.org/abs/2601.16175) | ||
| -/ | ||
|
|
||
| open Set | ||
|
|
||
| namespace Constant1a | ||
|
|
||
| /-- A real number satisfying a certain inequality about integral. -/ | ||
| def IsL2Bound (C : ℝ) : Prop := | ||
| ∀ ⦃f : ℝ → ℝ⦄, 0 ≤ f → C * (∫ x in (- 1 / 4)..(1 / 4), f x) ^ 2 | ||
| ≤ sSup {r | ∃ t ∈ Icc (1 / 2 : ℝ) 1, r = ∫ x, f (t - x) * f x} | ||
|
|
||
| /-- **Tao's Optimization constant 1a / An autocorrelation constant related to Sidon sets**: | ||
| The biggest real number satisfying a certain inequality about integral. -/ | ||
| noncomputable def C1a : ℝ := sSup {C : ℝ | IsL2Bound C} | ||
|
|
||
| /-- The best known lower bound, proven by Matolcsi-Vinuesa in-/ | ||
| @[category research solved, AMS 05 11 26] | ||
| theorem c1a_lower_bound : 1.2748 ≤ C1a := by | ||
| sorry | ||
|
|
||
| /-- The best known upper bound, proven by Yuksekgonul et al. in [Y2026] -/ | ||
| @[category research solved, AMS 05 11 26] | ||
| theorem c1a_upper_bound : C1a ≤ 1.5029 := by | ||
| sorry | ||
|
|
||
| /-- How can the upper bound be improved? -/ | ||
| @[category research open, AMS 05 11 26] | ||
| theorem c1a_le : C1a ≤ answer(sorry) := by | ||
| sorry | ||
|
|
||
| /-- How can the lower bound be improved? -/ | ||
| @[category research open, AMS 05 11 26] | ||
| theorem c1a_ge : answer(sorry) ≤ C1a := by | ||
| sorry | ||
|
|
||
| /-- What is the exact value of the constant? -/ | ||
| @[category research open, AMS 05 11 26] | ||
| theorem c1a_eq : C1a = answer(sorry) := by | ||
| sorry | ||
|
|
||
| -- TODO : Formalise relationship to Sidon sets. | ||
|
|
||
| end Constant1a | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this docstring could be a little more descriptive:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated the docstring. I hope its better now.
I dont think putting the entire inequality in the docstring makes sense though as its quite technical.