Skip to content

Speed up ray mesh by taking minimum instead of appending all distances #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srinathm1359
Copy link

I was using the ray_mesh code and found that it is appending all the distances from every triangle in the geom. Would it be more efficient if we append only the minimum of the distances (along with the corresponding id) rather than all the distances and ids? It might seem small but could easily add up with complicated mesh geoms having hundreds of thousands of triangles overall.

Changes:

  • Append the minimum distance instead of all distances (and the geom_id only once)
  • Obtain the minimum dist from the smaller array containing minimum distances instead of the array of all distances

Copy link

google-cla bot commented May 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant