Adding AgileX PiPER #149
Merged
Adding AgileX PiPER #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinzakka
requested changes
Feb 19, 2025
Collaborator
kevinzakka
left a comment
kevinzakka
left a comment
There was a problem hiding this comment.
Thank you for the PR Omar, this is great. Left some comments.
kevinzakka
reviewed
Feb 19, 2025
kevinzakka
requested changes
Feb 19, 2025
Contributor
Author
|
@kevinzakka comments resolved |
kevinzakka
reviewed
Feb 20, 2025
agilex_piper/piper.xml
Outdated
| </tendon> | ||
|
|
||
| <actuator> | ||
| <position name="joint1" joint="joint1" ctrlrange="-2.618 2.618" class="piper" /> |
Collaborator
There was a problem hiding this comment.
Remove the ctrlrange here and just add inheritrange="1" to the default class.
kevinzakka
requested changes
Feb 20, 2025
Collaborator
kevinzakka
left a comment
kevinzakka
left a comment
There was a problem hiding this comment.
Left one comment, other than that LGTM!
Contributor
Author
|
Resolved. Thanks |
kevinzakka
approved these changes
Feb 21, 2025
Collaborator
|
Thank you @omarrayyann!! |
copybara-service
bot
merged commit cd16545
into
google-deepmind:main
1 of 3 checks passed
donghoon11
pushed a commit
to donghoon11/mujoco_menagerie
that referenced
this pull request
May 7, 2025
donghoon11
pushed a commit
to donghoon11/mujoco_menagerie
that referenced
this pull request
May 7, 2025
PiperOrigin-RevId: 730169126 Change-Id: I07da84c67d3ff2eacc0f90acbee47882e13297e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-02-19.at.10.15.26.PM.mov