-
Notifications
You must be signed in to change notification settings - Fork 384
feat: Added fr3v2 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Added fr3v2 #194
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @AndreasKuhner, do the OBJ meshes converted from the DAE ones not have any of the usual colors (e.g. black bracelet) present on Franka arms? |
|
Hi @kevinzakka , And, maybe also some confusion -> the v2 looks a lot more 'clean' aka white. So no black bracelets (or as much as before) :)
|
|
Any update? Would I need to do something else? :) |
|
Hi @kevinzakka , Cheers, |
|
Hi @AndreasKuhner, sorry I'm behind on PRs. Will try to get to this as soon as I can. |
|
Any updates? :) |
franka_fr3_v2/README.md
Outdated
|
|
||
| ## Overview | ||
|
|
||
| This package contains a simplified robot description (MJCF) of the [Franka Research 3](https://franka.de/research) (aka FR3) developed by [Franka Robotics](https://franka.de/company) (formerly Franka Emika). It is derived from the [publicly available URDF description](https://github.com/frankaemika/franka_description). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the commit SHA this was taken at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess to reference which URDF we use here?
-> Added the tag/version of it.
| <img src="fr3.png" width="400"> | ||
| </p> | ||
|
|
||
| ## URDF → MJCF derivation steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm was this readme just copied from v1? What's the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is just a copy. Mostly visually the v2 is different from v1 (of course some internal changes here and there but nothing which is reflected by the URDFs).
43f6871 to
518ab6b
Compare
518ab6b to
eb1b112
Compare
|
What is the state with this PR? :) |
|
@kevinzakka can we have some updates here please. Thanks |

Description
Fixes:
Checklist
Please check off each item (
[x]) once complete, or mark it as[N/A]if it doesn't apply:CONTRIBUTORS.md(alphabetically by first name)CHANGELOG.md:pytest test/locally and ensured all tests passRefer to the contributing guide if you're unsure about any of the steps.