Forward **kwargs through Wrapper.render to the wrapped env - #327
Open
JJJEEERRR wants to merge 1 commit into
Open
Forward **kwargs through Wrapper.render to the wrapped env#327JJJEEERRR wants to merge 1 commit into
JJJEEERRR wants to merge 1 commit into
Conversation
The base `Wrapper.render` forwarded only a fixed set of positional arguments to `self.env.render`, silently dropping any extra render kwargs that custom environments define. This adds a `**kwargs` passthrough (and switches to keyword forwarding for clarity), so wrapped envs receive all render arguments. Adds a regression test that a wrapped env receives forwarded kwargs. Closes google-deepmind#258
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrapper.render(the base wrapper inmujoco_playground/_src/wrapper.py)forwarded only a fixed set of positional arguments to
self.env.render, so anyextra render keyword arguments defined by a custom environment were silently
dropped. This makes such kwargs reach the wrapped environment.
Fixes #258.
What changed
Wrapper.rendernow accepts and forwards**kwargstoself.env.render.for clarity at the call site.
WrapperTest.test_render_forwards_kwargs, a small regression test usinga recording env that asserts extra kwargs are passed through.
Backward compatibility
Fully backward compatible: existing call sites pass the same named arguments,
and envs whose
renderdoes not accept extra kwargs are unaffected because noextra kwargs are added by existing callers.