Skip to content

Conversation

@vincentzhang
Copy link
Contributor

This PR fixes issue #43 by replacing
json.dump(env_cfg.to_json(), fp, indent=4)
with
json.dump(env_cfg.to_dict(), fp, indent=4)
following the original suggestion.

@kevinzakka
Copy link
Collaborator

Thanks @vincentzhang !

@vincentzhang
Copy link
Contributor Author

vincentzhang commented Feb 12, 2025

The failed tests seem to be related to the previous commit at 3c2583b
It seems to be a new MuJoCo feature introduced in google-deepmind/mujoco@cef5b31
which is not in the current MuJoCo release (3.2.7).

Scope of impact of this API change:
mujoco_playground/_src/dm_control_suite/reacher.py
and the unit test in
mujoco_playground/_src/dm_control_suite/dm_control_suite_test.py

@kevinzakka
Copy link
Collaborator

I'm waiting for the new MuJoCo release which should be out next week. We can merge this PR then?

@vincentzhang
Copy link
Contributor Author

Good to know. Yeah I think this PR is good to go

@copybara-service copybara-service bot merged commit 0b021c9 into google-deepmind:main Feb 14, 2025
3 of 6 checks passed
mohamed-ashrafff pushed a commit to mohamed-ashrafff/mujoco_playground that referenced this pull request Jul 24, 2025
PiperOrigin-RevId: 727064864
Change-Id: I82a690120db8409e3687cb4bd2e30fa3a817083d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants