Update julia version to v1.10 #1380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok great!! Thanks. However, can you re-enable the Julia tests to it runs on Github Actions and we can see how long it takes? i.e. uncomment this: https://github.com/findmyway/open_spiel/blob/58b81463b4394772d72ba21d0a891acc7510245e/open_spiel/julia/CMakeLists.txt#L17 |
|
The CI failed. But I can't reproduce it with my local Mac environment. JuliaInterop/CxxWrap.jl#475 seems to be related. I'll find a linux environment and see how to fix it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]is the new Long-term support (LTS) release. This PR is an attempt to update the julia dependency.Note that #1379 is already integrated into this PR.
Though the tests are passed now, most of changes are introduced due to JuliaInterop/CxxWrap.jl#400 (comment) Ideally, we can have an option to turn on the original auto converting feature so that we don't need those verbose
[]dereference operations.