-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI fix and Deep CFR refactor #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lanctot I tried to unsuccessfully separate the development chain... |
|
as you wish! |
lanctot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try re-enabling the Linux arm64 tests too ?
|
@lanctot aren't they enabled?.. |
No probably because of the merge conflicts. See screenshot above: the "Files Changed".. wheels.yml shows them now as disabled again because they're currently commented out in master |
|
Hmmm, on my branch they are active, let me look once more https://github.com/alexunderch/open_spiel/blob/39c250a3f53eb2407ec17467524de9f546718c20/.github/workflows/wheels.yml#L43 |
|
Weird. I tried something (invoking my power as admin) and was able to make the commit even though it was in your branch. Cool. Now showing up in Flies Changed; let's see what happens! |
|
I think me and my interesting branching habits broke something. Will do my best not to happen in the future |
|
Sorry, I forgot to re-add the test for |
No problem. And: totally! Thanks for all your work over the past few days! |
|
It's only the first out of several big PRs. However, I believe that the next ones will be much simpler, because we would only need to focus on the tests rather than all of these dependencies... |


Brought back commented workflows just by replacing
CIBW_MANYLINUXimage frommanylinux_2014that's hit its EOL by:Added handselected pinned requirements.