Skip to content

Conversation

@alexunderch
Copy link
Contributor

Brought back commented workflows just by replacing CIBW_MANYLINUX image from manylinux_2014 that's hit its EOL by:

 CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
 CIBW_MANYLINUX_AARCH64_IMAGE: manylinux_2_28

Added handselected pinned requirements.

@alexunderch
Copy link
Contributor Author

alexunderch commented Jan 13, 2026

@lanctot lanctot changed the title CI fix CI fix and Deep CFR refactor Jan 13, 2026
@lanctot
Copy link
Collaborator

lanctot commented Jan 13, 2026

@lanctot I tried to unsuccessfully separate the development chain... Proof that this runs:

No problem. If tests pass... how about we just use this PR both as a fix for #1441 and as a replacement for #1408 ?

@alexunderch
Copy link
Contributor Author

as you wish!

Copy link
Collaborator

@lanctot lanctot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try re-enabling the Linux arm64 tests too ?

@alexunderch
Copy link
Contributor Author

@lanctot aren't they enabled?..

@lanctot
Copy link
Collaborator

lanctot commented Jan 13, 2026

Can you do one more commit to re-enable both of these commented Linux tests, in this PR, so they get triggered?

image

@lanctot
Copy link
Collaborator

lanctot commented Jan 13, 2026

@lanctot aren't they enabled?..

No probably because of the merge conflicts. See screenshot above: the "Files Changed".. wheels.yml shows them now as disabled again because they're currently commented out in master

@alexunderch
Copy link
Contributor Author

@lanctot
Copy link
Collaborator

lanctot commented Jan 13, 2026

Weird. I tried something (invoking my power as admin) and was able to make the commit even though it was in your branch. Cool. Now showing up in Flies Changed; let's see what happens!

@lanctot lanctot self-requested a review January 13, 2026 18:14
@alexunderch
Copy link
Contributor Author

I think me and my interesting branching habits broke something. Will do my best not to happen in the future

@lanctot lanctot mentioned this pull request Jan 13, 2026
@alexunderch
Copy link
Contributor Author

Sorry, I forgot to re-add the test for deep_cfr. But it's a good ending. Just another check and we're good to go. It was tough, but we did it, only sacrificing python3.10 and MacOS build for Intel.

@lanctot
Copy link
Collaborator

lanctot commented Jan 13, 2026

Sorry, I forgot to re-add the test for deep_cfr. But it's a good ending. Just another check and we're good to go. It was tough, but we did it, only sacrificing python3.10 and MacOS build for Intel.

No problem. And: totally! Thanks for all your work over the past few days!

@alexunderch
Copy link
Contributor Author

It's only the first out of several big PRs. However, I believe that the next ones will be much simpler, because we would only need to focus on the tests rather than all of these dependencies...

@lanctot
Copy link
Collaborator

lanctot commented Jan 13, 2026

image

@lanctot lanctot merged commit 248da93 into google-deepmind:master Jan 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants