refactor(sawtooth): move test references to local JSON file (#1762) #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eepmind#1762) - Add regenerate_sawtooth_refs.py for auto-regeneration of references - Add sawtooth_references.json with post-crash T_e, n_e, psi values - Update sawtooth_model_test.py to load references from JSON - Share test config between test and regeneration script (DRY) References regenerated against latest main. All 3 tests pass. Fixes google-deepmind#1762
Collaborator
|
Duplication of #1770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves hardcoded sawtooth crash reference values from sawtooth_model_test.py into a local sawtooth_references.json file, along with a regeneration script. This makes the test references maintainable and auto-regeneratable when the sawtooth model changes.
References were regenerated against the latest main to ensure they match current simulation output.
Fixes #1762
Changes
Files added:
Files modified:
Files NOT changed:
torax/_src/test_utils/references.jsontorax/_src/test_utils/torax_refs.py.nctest data filesNotes for Reviewers
rtol=1e-6)