Avoid tracer leak in jax.lax.cond by providing the arguments explicitly. #1945
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix issues with tracer leaks with the TGLFNN-UKAEA model while still allowing the use of cached_properties. This fixes issue #1939 PiperOrigin-RevId: 861826504
copybara-service
bot
force-pushed
the
test_861826504
branch
from
0b83343 to
8b06fdc
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
We found a better solution (#1945) to the tracer leak that will allow us to use cached_properties. Given that solution, we can revert this change. PiperOrigin-RevId: 861824572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid tracer leak in jax.lax.cond by providing the arguments explicitly.
This should fix issues with tracer leaks with the TGLFNN-UKAEA model while still allowing the use of cached_properties.
This fixes issue #1939