float16 - #55
Conversation
|
Hmm, I'm not sure actually. They will be read into a full-size float tensor, and I don't know without checking how safe the conversion of the small floats into large ones is, the way it is being done here. In the resulting float tensor, do you find the extra bits are set to zero? Or might they be uninitialized? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I have imprecise floating points that I'd like to keep small. I made this change to the torch-hdf5 code, and it seems to work fine. Am I overlooking anything here?