Simplified edge to edge #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android-dev-lxl
force-pushed
the
main-edge-to-edge
branch
from
200f690 to
7bc0578
Compare
yenerm
suggested changes
Jul 5, 2023
android-dev-lxl
force-pushed
the
main-edge-to-edge
branch
from
7bc0578 to
812e82d
Compare
yaraki
approved these changes
Jul 12, 2023
johnshea
suggested changes
Aug 29, 2023
There was a problem hiding this comment.
Update gradle wrapper to latest version. Currently 8.2
Update kotlinCompilerExtensionVersion to the latest.
Update BOM to the latest.
Project build.gradle.kts - Update all plugins to the latest versions
Type.kt - ln 31 - insert blank line to push comment down
Type.kt - ln 33 & ln 41 - remove blank lines for consistency
There was a problem hiding this comment.
Should the MaterialTheme shape value be used here?
There was a problem hiding this comment.
Yes, this was already reviewed by SMEs
There was a problem hiding this comment.
There are multiple occurences of 72.dp and 8.dp.
Can these be moved to the dimens.xml?
There was a problem hiding this comment.
There is no dimens.xml for this project.
johnshea
approved these changes
Aug 31, 2023
yenerm
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reference PR from Meghan: Woof edge to edge
Changes in this PR:
I would appreciate it if you could take a look at these changes and let me know.