Split and add Notebooks to Gemini Robotics#1138
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
Bot
added
status:awaiting review
Summary of ChangesHello @xpfgg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the existing Gemini Robotics content by moving it into a dedicated subdirectory and expanding it with new, detailed notebooks. The primary goal is to provide a more structured and comprehensive learning path for users interested in applying Gemini API features to robotics, focusing on determinism, latency control, and precise action. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively splits the robotics notebook into a more organized structure with a dedicated directory and README. The new robotics_api_features.ipynb notebook is a good addition. My review focuses on several areas for improvement in the new files to align with the repository's style guide and best practices. Specifically, I've pointed out a critical issue with an external dependency on a personal repository, and several medium-severity issues related to missing Colab badges, hardcoded model IDs, and inconsistent language use ('we' vs. 'you') as per the style guide. Addressing these will improve the quality, maintainability, and security of the new content.
| "from PIL import Image\n", | ||
| "\n", | ||
| "if not os.path.exists('robotics_utils.py'):\n", | ||
| " url = \"https://raw.githubusercontent.com/williamito/robotics-samples/refs/heads/main/robotics_utils.py\"\n", |
There was a problem hiding this comment.
This notebook downloads a utility script from a personal GitHub repository (williamito/robotics-samples). For security and maintainability, official cookbook examples must not depend on personal or unofficial repositories. Please vendor the robotics_utils.py script into this repository or another official Google-owned repository and update the URL.
|
|
||
| ## Notebooks | ||
|
|
||
| We recommend going through the notebooks in the following order: |
There was a problem hiding this comment.
According to the repository style guide (line 91), documentation should use the second person ('you') instead of 'we'. Please rephrase this sentence to avoid using 'we'. For example: 'The notebooks should be reviewed in the following order:'.
References
- Use second person: "you" rather than "we". You will fail the lint check otherwise. (link)
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "CZC64QGBZ2v9" | ||
| }, | ||
| "source": [ | ||
| "# Engineering Reliability (API Features)" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
According to the repository style guide (line 50), an 'Open in Colab' badge should be included in a new markdown cell immediately after the H1 title cell. This allows users to easily open the notebook in Colab.
The URL for the badge should be https://colab.research.google.com/github/google-gemini/cookbook/blob/main/quickstarts/gemini_robotics/robotics_api_features.ipynb.
References
- Include the "open in colab" button immediately after the
H1. It should look like<a target=\"_blank\" href=\"URL\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" height=30/>whereURLshould behttps://colab.research.google.com/github/google-gemini/cookbook/blob/main/followed by the notebook location in the cookbook. (link)
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "%pip install -U -q google-genai google-colab" |
There was a problem hiding this comment.
The style guide (line 25) specifies that the google-genai package should be installed with a minimum version to ensure compatibility and prevent issues with older versions.
| "%pip install -U -q google-genai google-colab" | |
| "%pip install -U -q 'google-genai>=1.0.0' google-colab" |
References
%pip install -U -q 'google-genai>=1.0.0'is the right way to install the SDK. The version indicated should reflect the minimum version needed to use the features used in the notebook (1.0.0 by default or in doubt). (link)
| "\n", | ||
| "GOOGLE_API_KEY = userdata.get(\"GOOGLE_API_KEY\")\n", | ||
| "client = genai.Client(api_key=GOOGLE_API_KEY)\n", | ||
| "MODEL_ID = \"gemini-3-flash-preview\"" |
There was a problem hiding this comment.
The style guide (line 72) recommends using a Colab form element for model selection to improve maintainability and allow users to easily experiment. Since this notebook has specific model requirements for the 'Thinking' feature, using a simple input field is appropriate.
MODEL_ID = "gemini-3-flash-preview" # @param {type:"string"}
References
- When selecting a model, use a colab selector for easier maintainability. (link)
| }, | ||
| "source": [ | ||
| "### Example: Eliminating Filler Text\n", | ||
| "By enforcing JSON mode, we create a strict contract between the AI and our robot controller, ensuring the output is always machine-readable." |
There was a problem hiding this comment.
The style guide (line 91) recommends using the second person ('you') instead of 'we' to maintain a consistent voice across all documentation.
"By enforcing JSON mode, you create a strict contract between the AI and your robot controller, ensuring the output is always machine-readable."
References
- Use second person: "you" rather than "we". You will fail the lint check otherwise. (link)
|
Hi @xpfgg, thank you for this extensive contribution! Could you please resolve these formatting issues? In the meantime, since this PR introduces multiple new files and creates a new subdirectory, I will discuss these structural changes with the core team and get back to you shortly! |
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:44Z Line #1. %pip install -U -q google-genai google-colab I don't think you need |
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:45Z Line #5. url = "https://raw.githubusercontent.com/williamito/robotics-samples/refs/heads/rewrite/robotics_utils.py?token=GHSAT0AAAAAADS2JPNJS7O2QV5K5PIIT25Q2L37DKQ" I think this should not live in a private repo. Can you move it to the cookbook too? I also think you need to explain what those functions are doing, especially |
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:45Z Line #2. model_name = "gemini-3-flash-preview" Model selector please, especially since you want the users to be able to easily switch to the ER model. Also uniformize how the model id is named and use |
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:46Z Line #6. thinking_config={"thinking_budget": 0} # Thinking off
Explain why the thinking is off |
| @@ -0,0 +1,303 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #7. MODEL_ID = "gemini-3-flash-preview"
Can you add a modle selector (as everywhere else you are using gemini models)? (cf. styleguide.md or CONTRIBUTING.md)
Reply via ReviewNB
| @@ -0,0 +1,303 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,303 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,303 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe point to other interesting notebook, like the gemeini get started one, the robotics get started one as well. Yoàu should not assume that users will read your four notebooks in the right order and that they could start with any one and then be interested in the other.
Reply via ReviewNB
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:50Z Output is missing, please rerun |
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:51Z Add output |
|
View / edit / reply to this conversation on ReviewNB Giom-V commented on 2026-04-29T08:49:51Z Add a link to the other 2 spatial understanding notebooks already in the cookbook (and vice-versa). And also wayme it would be worth explaining what this one has that the others don't. |
| @@ -0,0 +1,529 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,529 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #6. Comparing the start of the episode (first 4 images) with the current state (last 4 images),
Please indent the multi-line string.
Reply via ReviewNB
| @@ -0,0 +1,529 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #35. You have functions: move(x, y, high), setGripper(opened).
PLease indent.
Reply via ReviewNB
| @@ -0,0 +1,529 @@ | |||
| { | |||
There was a problem hiding this comment.
Add more links if possible (at the very least to the main get started with robotics notbook)
Reply via ReviewNB
|
@xpfgg did a first pass of review. I did'nt comment everything but most of the comment apply to multiple places in the notebooks. Please also check the issues reported by gemini as they are also relevant and the same as mine sometimes. |
3 participants
No description provided.