Skip to content

fix(cli): add explicit dependency on color-convert#16757

Merged
sehoon38 merged 1 commit into
mainfrom
fix/docker-color-convert
Jan 15, 2026
Merged

fix(cli): add explicit dependency on color-convert#16757
sehoon38 merged 1 commit into
mainfrom
fix/docker-color-convert

Conversation

@sehoon38

@sehoon38 sehoon38 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds color-convert as an explicit dependency to @google/gemini-cli. This resolves a critical Module not found error encountered when running the CLI in Docker environments, likely caused by dependency hoisting behavior during the global installation from the packed tarball.

Details

  • The error Error: Cannot find module 'color-convert' was observed in Docker.
  • Although color-convert is a transitive dependency via ink-gradient -> gradient-string -> chalk -> ansi-styles, it was not being correctly resolved in the Docker runtime environment.
  • Explicitly adding it to packages/cli/package.json ensures it is installed as a direct dependency, guaranteeing its availability.

Related Issues

Fixes #16745
N/A

How to Validate

  1. Build the CLI package: npm run build:packages
  2. Build the Docker image.
  3. Run the CLI container and verify it starts without the "Cannot find module 'color-convert'" error.
  4. Locally: npm install and npm run start should continue to work on macOS/Linux.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@sehoon38 sehoon38 requested a review from a team as a code owner January 15, 2026 18:20
@gemini-cli

gemini-cli Bot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical Module not found error that prevented the CLI from running correctly in Docker environments. The issue stemmed from color-convert being a transitive dependency, which, due to dependency hoisting, was not reliably resolved in containerized setups. By making color-convert an explicit direct dependency, the CLI's stability and portability across different environments are significantly improved.

Highlights

  • Dependency Fix: Explicitly added color-convert as a direct dependency to the @google/gemini-cli package.
  • Docker Compatibility: Resolves a critical Module not found error for color-convert that occurred when running the CLI in Docker environments.
  • Dependency Resolution: Addresses issues related to dependency hoisting behavior, ensuring that color-convert is always available, even though it was previously a transitive dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a critical Module not found error by adding color-convert as an explicit dependency to @google/gemini-cli. This is a standard and effective solution for issues with transitive dependency resolution, particularly in containerized environments like Docker. The change is minimal, well-targeted, and the accompanying updates to package-lock.json are as expected. I find no issues with this approach. Excellent work on identifying and resolving this dependency issue.

@github-actions

Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 23.1 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@sehoon38 sehoon38 enabled auto-merge January 15, 2026 18:24
@sehoon38 sehoon38 added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit c8670f8 Jan 15, 2026
26 checks passed
@sehoon38 sehoon38 deleted the fix/docker-color-convert branch January 15, 2026 19:13
@mgudim

mgudim commented Jan 16, 2026

Copy link
Copy Markdown

Hi, thank you for looking into this.

While this is a necessary fix I guess, I don't think this addresses the root cause of my problem (#16745). Two weeks later I may have a similar problem with another dependency. I would really prefer if there was a way to disable automatic updates. In the docker environment I do not see any config files. Setting environment variable did not turn off the updates.

@sehoon38 @gundermanc @scidomino

Thomas-Shephard pushed a commit to Thomas-Shephard/gemini-cli that referenced this pull request Jan 21, 2026
thacio added a commit to thacio/auditaria that referenced this pull request Jan 24, 2026
kuishou68 pushed a commit to iOfficeAI/gemini-cli-pro that referenced this pull request Feb 27, 2026
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find module color-convert

5 participants