fix(cli): handle optional ping in mcp list

[jasonmatthewsuhari]

Fixes #25599

Summary

• align gemini mcp list connection checks with the shared MCP default timeout instead of a hardcoded 5s timeout
• treat ping() as best-effort in mcp list so servers that return MethodNotFound after a successful MCP initialize handshake are still reported as connected
• add focused regression tests for both the timeout behavior and the unsupported ping() case

Verification

• reproduced the issue against https://run.googleapis.com/mcp, where gemini mcp list reported Disconnected before the fix
• verified the patched local CLI reports cloud-run: https://run.googleapis.com/mcp (http) - Connected

Reproduced:

Resolved:

[jasonmatthewsuhari]

/gemini review

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of the MCP server connection checks within the CLI. By aligning timeouts with global defaults and making the ping verification step best-effort, the CLI now correctly identifies and reports servers that are functional but do not support the optional ping protocol.

Highlights

• Connection Timeout Alignment: Updated the MCP connection check to use the shared default timeout instead of a hardcoded 5-second limit.
• Best-Effort Ping Handling: Modified the connection logic to treat ping failures caused by 'MethodNotFound' as successful connections, ensuring compatibility with servers that do not implement the ping method.
• Regression Testing: Added new test cases to verify correct timeout behavior and ensure servers remain marked as connected even when ping is unsupported.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the MCP connection testing logic in the CLI. It replaces the hardcoded 5-second timeout with a configurable timeout that defaults to MCP_DEFAULT_TIMEOUT_MSEC. Additionally, it improves the robustness of the connection check by treating MethodNotFound errors during the ping phase as a successful connection, acknowledging that some MCP servers may not implement the ping method. New test cases have been added to verify these behaviors. I have no feedback to provide.

[gemini-code-assist]

Code Review

This pull request updates the MCP connection testing logic to use a configurable or shared default timeout (MCP_DEFAULT_TIMEOUT_MSEC) instead of a hardcoded value. It also improves robustness by treating MethodNotFound errors during the ping phase as a successful connection, acknowledging that some MCP servers may not implement the ping method. Corresponding unit tests have been added to verify these behaviors. I have no feedback to provide.