fix(cli): copy extension examples to dist during build#25653
fix(cli): copy extension examples to dist during build#25653lynn901 wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
The 'gemini extensions new' command was failing because the extension example templates were not included in the published package. This adds a step to copy the examples directory to dist/src/commands/extensions/examples during the CLI package build process.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a packaging issue where required extension example templates were missing from the CLI distribution. By updating the build process to explicitly copy these assets, the CLI will now correctly provide the necessary files for users to initialize new extensions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the build script to copy extension examples for the CLI package into the distribution directory. A review comment suggests adjusting the target path to exclude the 'src' segment to match the compiled code structure and adding the 'dereference' option to ensure symlinks are correctly resolved.
| const examplesSource = join(process.cwd(), 'src', 'commands', 'extensions', 'examples'); | ||
| const examplesTarget = join(process.cwd(), 'dist', 'src', 'commands', 'extensions', 'examples'); | ||
| if (existsSync(examplesSource)) { | ||
| cpSync(examplesSource, examplesTarget, { recursive: true }); | ||
| console.log('Copied extension examples to dist/src/commands/extensions/examples/'); | ||
| } |
There was a problem hiding this comment.
The target path currently includes a src/ segment inside the dist/ directory. However, the package.json for the CLI specifies "main": "dist/index.js", which indicates that the TypeScript compiler is configured to strip the src prefix (likely via rootDir: "src"). Consequently, the examples should be copied to dist/commands/... to match the structure of the compiled code. Additionally, using dereference: true is recommended to ensure any symlinks in the templates are resolved, matching the pattern used for the core package's documentation.
| const examplesSource = join(process.cwd(), 'src', 'commands', 'extensions', 'examples'); | |
| const examplesTarget = join(process.cwd(), 'dist', 'src', 'commands', 'extensions', 'examples'); | |
| if (existsSync(examplesSource)) { | |
| cpSync(examplesSource, examplesTarget, { recursive: true }); | |
| console.log('Copied extension examples to dist/src/commands/extensions/examples/'); | |
| } | |
| const examplesSource = join(process.cwd(), 'src', 'commands', 'extensions', 'examples'); | |
| const examplesTarget = join(process.cwd(), 'dist', 'commands', 'extensions', 'examples'); | |
| if (existsSync(examplesSource)) { | |
| cpSync(examplesSource, examplesTarget, { recursive: true, dereference: true }); | |
| console.log('Copied extension examples to dist/commands/extensions/examples/'); | |
| } |
The 'gemini extensions new' command was failing because the extension example templates were not included in the published package. This adds a step to copy the examples directory to dist/src/commands/extensions/examples during the CLI package build process.
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist