Skip to content

Akkr/gemma4 apr19#25666

Open
akh64bit wants to merge 4 commits intomainfrom
akkr/gemma4_apr19
Open

Akkr/gemma4 apr19#25666
akh64bit wants to merge 4 commits intomainfrom
akkr/gemma4_apr19

Conversation

@akh64bit
Copy link
Copy Markdown
Contributor

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@akh64bit akh64bit requested review from a team as code owners April 19, 2026 18:56
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the model selection process by removing the dynamic model routing service in favor of a fixed model, 'gemma-4-26b-a4b-it'. These changes affect both the core client and the local agent executor, necessitating updates to configuration constants and a significant refactoring of the associated test suites to accommodate the new static model assignment.

Highlights

  • Model Selection Update: Replaced dynamic model routing with a hardcoded selection of 'gemma-4-26b-a4b-it' in the Gemini client and local executor.
  • Configuration Changes: Added 'GEMMA_4_MODEL' to the available models configuration.
  • Test Suite Adjustments: Updated existing tests to reflect the new model selection logic and skipped several tests related to the removed model routing functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the dynamic model routing logic from the LocalAgentExecutor and GeminiClient. In LocalAgentExecutor, "auto" models now default to PREVIEW_GEMINI_FLASH_MODEL, while GeminiClient has been updated to hardcode the use of the new GEMMA_4_MODEL (gemma-4-26b-a4b-it). Correspondingly, several tests related to model routing, availability services, and stream retries have been skipped or updated to reflect these changes. I have no feedback to provide as there were no review comments to evaluate.

@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant