chore: clean up launched memory features#26941
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the memory management architecture by removing legacy experimental features, specifically the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the legacy save_memory tool and the experimental flags experimental.memoryV2 and experimental.jitContext, establishing direct markdown file editing as the primary method for persisting agent memory. The changes involve a comprehensive cleanup of documentation, removal of the /memory add slash command, and deletion of the MemoryTool class and its related logic and tests across the monorepo. I have no feedback to provide.
|
Size Change: -25.3 kB (-0.07%) Total Size: 34.1 MB
ℹ️ View Unchanged
|
gemini-cli
Bot
added
area/agent
SandyTao520
force-pushed
the
st/chore/clean-up-memory
branch
from
cb00807 to
a1d8407
Compare
SandyTao520
force-pushed
the
st/chore/clean-up-memory
branch
from
a1d8407 to
e431f6e
Compare
|
✅ 64 tests passed successfully on gemini-3-flash-preview. 🧠 Model Steering GuidanceThis PR modifies files that affect the model's behavior (prompts, tools, or instructions).
This is an automated guidance message triggered by steering logic signatures. |
Co-authored-by: Jenna Inouye <jinouye@google.com>
Co-authored-by: Jenna Inouye <jinouye@google.com>
Co-authored-by: Jenna Inouye <jinouye@google.com>
Co-authored-by: Jenna Inouye <jinouye@google.com>
Co-authored-by: Jenna Inouye <jinouye@google.com>
# Conflicts: # packages/cli/src/config/config.ts
# Conflicts: # packages/core/src/utils/memoryDiscovery.test.ts # packages/core/src/utils/memoryDiscovery.ts
3 participants
Summary
Clean up the false-path code for launched JIT context and memory behavior. This removes the old experimental settings, legacy memory loading/tool surfaces, and docs/tests that described the disabled modes.
Details
save_memorytool,/memory add, memory-manager policy, and old server hierarchical memory loader.save_memorytool.Related Issues
#22098
How to Validate
npm run typecheck --workspace @google/gemini-cli-corenpm run typecheck --workspace @google/gemini-clinpm run typecheck --workspace @google/gemini-cli-a2a-servernpx tsc -b evals/tsconfig.json --pretty falsenpx vitest run src/config/config.test.ts src/utils/memoryDiscovery.test.tsfrompackages/corenpx vitest run src/tools/jit-context.test.ts src/tools/read-file.test.ts src/tools/read-many-files.test.ts src/tools/write-file.test.ts src/tools/edit.test.ts src/tools/ls.test.tsfrompackages/corenpx vitest run src/prompts/snippets-memory.test.ts src/prompts/promptProvider.test.ts src/core/prompts.test.tsfrompackages/corenpx vitest run src/ui/commands/directoryCommand.test.tsx src/ui/hooks/useIncludeDirsTrust.test.tsx src/config/config.test.ts src/config/workspace-policy-cli.test.ts src/ui/utils/directoryUtils.test.tsfrompackages/clinpx vitest run src/config/config.test.ts src/commands/memory.test.tsfrompackages/a2a-serverPre-Merge Checklist