fix: resolve monorepo type errors and stabilize build#26960
Draft
gemini-cli[bot] wants to merge 2 commits into
Draft
fix: resolve monorepo type errors and stabilize build#26960gemini-cli[bot] wants to merge 2 commits into
gemini-cli[bot] wants to merge 2 commits into
Conversation
This PR addresses several critical build and type-checking issues across the monorepo: 1. **Core Package Stability**: Removed deprecated `baseUrl` from `packages/core/tsconfig.json` and converted absolute-style imports to relative paths. This allows `tsc --build` to succeed reliably. 2. **Modern JS API Support**: Upgraded `lib` to `ES2023` in `packages/test-utils` and `packages/vscode-ide-companion` to resolve errors related to `Error.cause` and other modern JavaScript features. 3. **SDK Type Integrity**: Fixed several `noImplicitAny` errors and resolved inheritance issues in `SdkTool` and `SdkToolInvocation` by refining generic constraints and adding necessary ESLint disable comments for complex type bypasses. 4. **DevTools ESM Compliance**: Added missing `.js` extensions to relative imports in the DevTools client and fixed un-typed property access in log objects. 5. **Build Graph Optimization**: Added missing project references in `test-utils` and removed redundant `paths` in `evals` to ensure correct build order and declaration resolution. These changes collectively restore the ability to run `npm run typecheck` and `npm run build` across the entire project. cc @google-gemini/gemini-cli-maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: resolve monorepo type errors and stabilize build
This PR addresses several critical build and type-checking issues across the monorepo:
baseUrlfrompackages/core/tsconfig.jsonand converted absolute-style imports to relative paths. This allowstsc --buildto succeed reliably.libtoES2023inpackages/test-utilsandpackages/vscode-ide-companionto resolve errors related toError.causeand other modern JavaScript features.noImplicitAnyerrors and resolved inheritance issues inSdkToolandSdkToolInvocationby refining generic constraints and adding necessary ESLint disable comments for complex type bypasses..jsextensions to relative imports in the DevTools client and fixed un-typed property access in log objects.test-utilsand removed redundantpathsinevalsto ensure correct build order and declaration resolution.These changes collectively restore the ability to run
npm run typecheckandnpm run buildacross the entire project.cc @google-gemini/gemini-cli-maintainers