fix(core): buffer chat compression telemetry#27020
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes telemetry handling for chat compression by transitioning from immediate execution to a buffered approach for OpenTelemetry events and associated metrics. By utilizing the existing bufferTelemetryEvent utility, the system reduces overhead while ensuring that critical Clearcut logging remains unaffected and synchronous. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modifies the logChatCompression function in packages/core to wrap OpenTelemetry logging and metrics recording inside bufferTelemetryEvent, ensuring these events are buffered. A new unit test has been added to loggers.test.ts to verify this behavior and ensure that ClearcutLogger is still called. I have no feedback to provide.
Summary
Fixes #23445.
Validation