Skip to content

fix(core): buffer chat compression telemetry#27020

Open
pragnyanramtha wants to merge 1 commit into
google-gemini:mainfrom
pragnyanramtha:fix-telemetry-buffer-23445-forksafe
Open

fix(core): buffer chat compression telemetry#27020
pragnyanramtha wants to merge 1 commit into
google-gemini:mainfrom
pragnyanramtha:fix-telemetry-buffer-23445-forksafe

Conversation

@pragnyanramtha
Copy link
Copy Markdown

Summary

  • wrap chat compression OTel logging in bufferTelemetryEvent
  • buffer the associated chat compression metrics call with the OTel event
  • keep Clearcut chat compression logging immediate

Fixes #23445.

Validation

  • npx vitest run packages/core/src/telemetry/loggers.test.ts
  • npx eslint packages/core/src/telemetry/loggers.ts packages/core/src/telemetry/loggers.test.ts --max-warnings 0
  • npx prettier --check packages/core/src/telemetry/loggers.ts packages/core/src/telemetry/loggers.test.ts
  • git diff --check origin/main...HEAD
  • git merge-tree origin/main fix-telemetry-buffer-23445-forksafe

@pragnyanramtha pragnyanramtha requested a review from a team as a code owner May 13, 2026 21:53
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes telemetry handling for chat compression by transitioning from immediate execution to a buffered approach for OpenTelemetry events and associated metrics. By utilizing the existing bufferTelemetryEvent utility, the system reduces overhead while ensuring that critical Clearcut logging remains unaffected and synchronous.

Highlights

  • Telemetry Buffering: Wrapped chat compression OpenTelemetry logging and metrics recording within the bufferTelemetryEvent function to improve performance.
  • Logging Consistency: Maintained immediate logging for Clearcut chat compression events while deferring OTel and metrics processing.
  • Test Coverage: Added a new test case to verify that chat compression events and metrics are correctly buffered rather than emitted immediately.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the logChatCompression function in packages/core to wrap OpenTelemetry logging and metrics recording inside bufferTelemetryEvent, ensuring these events are buffered. A new unit test has been added to loggers.test.ts to verify this behavior and ensure that ClearcutLogger is still called. I have no feedback to provide.

@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality area/enterprise Issues related to Telemetry, Policy, Quota / Licensing labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality area/enterprise Issues related to Telemetry, Policy, Quota / Licensing priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug(telemetry): logChatCompression bypasses bufferTelemetryEvent wrapper

1 participant