test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions#27755
test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions#27755aniruddhaadak80 wants to merge 1 commit into
Conversation
|
📊 PR Size: size/S
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the test suite for the a2a-server package to align with project standards for environment variable handling. By utilizing Vitest's built-in stubbing utilities, the changes improve test reliability and prevent side effects caused by direct manipulation of the global process.env object. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the test files init.test.ts and app.test.ts in packages/a2a-server to follow the repository's testing conventions for environment variables. Specifically, direct modifications to process.env are replaced with vi.stubEnv and vi.unstubAllEnvs() to prevent test leakage. There are no review comments, and I have no feedback to provide.
Fixes #19826
Replaced direct \process.env\ modifications with \�i.stubEnv()\ and \�i.unstubAllEnvs()\ in \packages/a2a-server/src/commands/init.test.ts\ and \packages/a2a-server/src/http/app.test.ts, following the guidelines in GEMINI.md.