Skip to content

test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions#27755

Open
aniruddhaadak80 wants to merge 1 commit into
google-gemini:mainfrom
aniruddhaadak80:fix-issue-19826
Open

test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions#27755
aniruddhaadak80 wants to merge 1 commit into
google-gemini:mainfrom
aniruddhaadak80:fix-issue-19826

Conversation

@aniruddhaadak80

Copy link
Copy Markdown
Contributor

Fixes #19826

Replaced direct \process.env\ modifications with \�i.stubEnv()\ and \�i.unstubAllEnvs()\ in \packages/a2a-server/src/commands/init.test.ts\ and \packages/a2a-server/src/http/app.test.ts, following the guidelines in GEMINI.md.

@aniruddhaadak80 aniruddhaadak80 requested a review from a team as a code owner June 9, 2026 14:17
@github-actions github-actions Bot added the size/s A small PR label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

📊 PR Size: size/S

  • Lines changed: 15
  • Additions: +10
  • Deletions: -5
  • Files changed: 2

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test suite for the a2a-server package to align with project standards for environment variable handling. By utilizing Vitest's built-in stubbing utilities, the changes improve test reliability and prevent side effects caused by direct manipulation of the global process.env object.

Highlights

  • Environment Variable Management: Replaced direct modifications of process.env with Vitest's vi.stubEnv() and vi.unstubAllEnvs() to ensure environment variable isolation during tests.
  • Test Lifecycle Cleanup: Added vi.unstubAllEnvs() to afterEach hooks in test files to prevent environment pollution between test cases.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the test files init.test.ts and app.test.ts in packages/a2a-server to follow the repository's testing conventions for environment variables. Specifically, direct modifications to process.env are replaced with vi.stubEnv and vi.unstubAllEnvs() to prevent test leakage. There are no review comments, and I have no feedback to provide.

@gemini-cli gemini-cli Bot added priority/p3 Backlog - a good idea but not currently a priority. area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! priority/p3 Backlog - a good idea but not currently a priority. size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions

1 participant