Skip to content

test(core): add subfolder ignore test for getFolderStructure#27788

Open
fallofpheonix wants to merge 1 commit into
google-gemini:mainfrom
fallofpheonix:fix-session-context-ignore
Open

test(core): add subfolder ignore test for getFolderStructure#27788
fallofpheonix wants to merge 1 commit into
google-gemini:mainfrom
fallofpheonix:fix-session-context-ignore

Conversation

@fallofpheonix

Copy link
Copy Markdown

This PR adds a test case to verify that getFolderStructure correctly respects .gitignore rules for files in subdirectories when specified in the root .gitignore. This relates to issue #27787.

@fallofpheonix fallofpheonix requested a review from a team as a code owner June 10, 2026 12:12
@google-cla

google-cla Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the test suite for the folder structure discovery utility by ensuring that ignore patterns defined in a root .gitignore file are properly applied to nested files. This change helps validate the expected behavior for file filtering and addresses concerns related to issue #27787.

Highlights

  • Test Coverage Expansion: Added a new test case to verify that the getFolderStructure utility correctly respects .gitignore rules for files located within subdirectories.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/s A small PR label Jun 10, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/S

  • Lines changed: 17
  • Additions: +17
  • Deletions: -0
  • Files changed: 1

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a unit test to getFolderStructure.test.ts to verify that files in subdirectories specified in the root .gitignore are correctly ignored. I have no feedback to provide as there are no review comments.

@gemini-cli gemini-cli Bot added the area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality label Jun 10, 2026
@gemini-cli gemini-cli Bot added the priority/p2 Important but can be addressed in a future release. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality priority/p2 Important but can be addressed in a future release. size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant