Skip to content

fix(ci): append trailing slash to registry url in npmrc#28038

Merged
rmedranollamas merged 1 commit into
google-gemini:mainfrom
rmedranollamas:fix/registry-auth-trailing-slash
Jun 19, 2026
Merged

fix(ci): append trailing slash to registry url in npmrc#28038
rmedranollamas merged 1 commit into
google-gemini:mainfrom
rmedranollamas:fix/registry-auth-trailing-slash

Conversation

@rmedranollamas

@rmedranollamas rmedranollamas commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR appends a trailing slash to the @google registry URL in both the root .npmrc and .github/actions/setup-npmrc/action.yml. This fixes the nightly release credential mapping issue where npm was unable to match credentials with the registry.

Details

Without the trailing slash (/), npm publish fails with ENEEDAUTH because the registry endpoint https://wombat-dressing-room.appspot.com/ (which npm resolves with a trailing slash) does not match the exact key //wombat-dressing-room.appspot.com:_authToken or similar credential mapping without the slash. Aligning both files to include the trailing slash resolves this authentication mismatch.

Related Issues

Fixes #28029 Fixes #28028 Fixes #28026 Fixes #27991 Fixes #27955

How to Validate

Validate that the setup is syntactically correct and aligns with standard npm scoped registry configurations:

  1. Ensure .npmrc matches the setup-npmrc action configuration.
  2. The nightly release workflow will utilize the setup-npmrc action, where @google:registry=https://wombat-dressing-room.appspot.com/ is properly written.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@rmedranollamas rmedranollamas requested a review from a team as a code owner June 19, 2026 11:09
@github-actions github-actions Bot added the size/xs An extra small PR label Jun 19, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XS

  • Lines changed: 4
  • Additions: +2
  • Deletions: -2
  • Files changed: 2

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an authentication issue during npm publish by ensuring the @google registry URL configuration includes a trailing slash. This alignment resolves mismatches between the registry endpoint and the credential mapping, preventing ENEEDAUTH errors in the nightly release workflow.

Highlights

  • Registry URL Configuration: Appended a trailing slash to the @google registry URL in both the root .npmrc and the setup-npmrc GitHub action to ensure proper credential matching.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @google registry URL by appending a trailing slash in both .github/actions/setup-npmrc/action.yml and .npmrc. I have no feedback to provide.

@gemini-cli gemini-cli Bot added priority/p1 Important and should be addressed in the near term. area/non-interactive Issues related to GitHub Actions, SDK, 3P Integrations, Shell Scripting, Command line automation labels Jun 19, 2026
@rmedranollamas rmedranollamas enabled auto-merge June 19, 2026 11:41
@rmedranollamas rmedranollamas added this pull request to the merge queue Jun 19, 2026
Merged via the queue into google-gemini:main with commit 6613e12 Jun 19, 2026
33 checks passed
@rmedranollamas rmedranollamas deleted the fix/registry-auth-trailing-slash branch June 19, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/non-interactive Issues related to GitHub Actions, SDK, 3P Integrations, Shell Scripting, Command line automation priority/p1 Important and should be addressed in the near term. size/xs An extra small PR

Projects

None yet

2 participants